basic cli and first draft command for ct module #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/ct_types #1929 +/- ##
====================================================
- Coverage 61.36% 61.12% -0.24%
====================================================
Files 263 275 +12
Lines 23306 24427 +1121
====================================================
+ Hits 14301 14931 +630
- Misses 8001 8403 +402
- Partials 1004 1093 +89
|
…into ct_client_init_account
mj850
approved these changes
Nov 14, 2024
aclmapping/utils/resource_type.go
Outdated
| @@ -101,6 +102,10 @@ var StoreKeyToResourceTypePrefixMap = aclsdktypes.StoreKeyToResourceTypePrefixMa | |||
| aclsdktypes.ResourceType_KV_TOKENFACTORY_ADMIN: []byte(tokenfactorytypes.AdminPrefixKey), | |||
| aclsdktypes.ResourceType_KV_TOKENFACTORY_CREATOR: []byte(tokenfactorytypes.AdminPrefixKey), | |||
| }, | |||
| cttypes.StoreKey: { | |||
| //aclsdktypes.ResourceType_KV_CT: aclsdktypes.EmptyPrefix, | |||
There was a problem hiding this comment.
When do we uncomment these? Should we add a TODO here?
aclmapping/utils/resource_type.go
Outdated
| @@ -211,6 +216,10 @@ var ResourceTypeToStoreKeyMap = aclsdktypes.ResourceTypeToStoreKeyMap{ | |||
| aclsdktypes.ResourceType_KV_TOKENFACTORY_ADMIN: tokenfactorytypes.StoreKey, | |||
| aclsdktypes.ResourceType_KV_TOKENFACTORY_CREATOR: tokenfactorytypes.StoreKey, | |||
|
|
|||
| // ~~~~ CONFIDENTIAL TRANSFERS Resource Types ~~~~ | |||
There was a problem hiding this comment.
Likewise, maybe we should add a note here for when to uncomment these
app/app.go
Outdated
| @@ -1081,6 +1081,15 @@ func (app *App) SetStoreUpgradeHandlers() { | |||
| // configure store loader that checks if version == upgradeHeight and applies store upgrades | |||
| app.SetStoreLoader(upgradetypes.UpgradeStoreLoader(upgradeInfo.Height, &storeUpgrades)) | |||
| } | |||
|
|
|||
| if (upgradeInfo.Name == "v6.1.0") && !app.UpgradeKeeper.IsSkipHeight(upgradeInfo.Height) { | |||
There was a problem hiding this comment.
Just curious, what is this used for?
x/confidentialtransfers/module.go
Outdated
| @@ -103,8 +99,7 @@ func (AppModuleBasic) RegisterGRPCGatewayRoutes(clientCtx client.Context, mux *r | |||
| // TODO: Implement this when we add the CLI methods | |||
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mj850
pushed a commit
that referenced
this pull request
Dec 7, 2024
* basic cli and first draft command for ct module * add second command draft * draft of init account * close account update * lint errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
basic cli and first draft command for ct module
Testing performed to validate your change